Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14888 )
Change subject: IMPALA-9237: Make package binutils building work on aarch64 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14888/1/init-compiler.sh File init-compiler.sh: http://gerrit.cloudera.org:8080/#/c/14888/1/init-compiler.sh@77 PS1, Line 77: if [[ "$ARCH_NAME" == "aarch64" ]]; then Can you make this an if/else like the other cases for consistency, e.g. if [[ "$ARCH_NAME" == "aarch64" ]]; then CXXFLAGS="$ARCH_FLAGS -fPIC -O3" else CXXFLAGS="$ARCH_FLAGS -fPIC -O3 -m64" fi -- To view, visit http://gerrit.cloudera.org:8080/14888 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08dbe29357a191b0bfd96a76d1f9d58616880905 Gerrit-Change-Number: 14888 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 12 Dec 2019 18:47:36 +0000 Gerrit-HasComments: Yes
