[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/14888 )
Change subject: IMPALA-9237: Make package binutils building work on aarch64 ...................................................................... Patch Set 2: (1 comment) Tim Armstrong, Thanks for reviewing it:) http://gerrit.cloudera.org:8080/#/c/14888/1/init-compiler.sh File init-compiler.sh: http://gerrit.cloudera.org:8080/#/c/14888/1/init-compiler.sh@77 PS1, Line 77: CXXFLAGS="$ARCH_FLAGS -fPIC -O3" > Can you make this an if/else like the other cases for consistency, e.g. Done -- To view, visit http://gerrit.cloudera.org:8080/14888 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08dbe29357a191b0bfd96a76d1f9d58616880905 Gerrit-Change-Number: 14888 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 13 Dec 2019 02:11:13 +0000 Gerrit-HasComments: Yes
