Hello Thomas Tauber-Marshall, Lars Volker, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14882
to look at the new patch set (#2).
Change subject: IMPALA-9138: Classify certain errors as retryable
......................................................................
IMPALA-9138: Classify certain errors as retryable
This patch modifies Status objects so they can be classified as
"Retryable". This is modelled using a new field in TStatus called
TStatusProperties. TStatusProperties is a struct of properties used to
describe a TStatus object.
SetIsRetryable() can be used to mark a Status as "Retryable" and
IsRetryable() can be used to check if a method is retryable or not
(similar to IsRecoverable() or IsInternalError()).
Currently, if a Status is marked as "Retryable"
(e.g. Status::IsRetryable() == true), nothing happens. The change is
simply meant to lay the groundwork for future changes in IMPALA-9124.
ReportExecStatusRequestPB::overall_status is modified so that it tracks
the merged properties of all failed fragment instances.
This patch extends the usage of TStatusProperties to create "Recoverable"
errors as well, which replaces the current RECOVERABLE TErrorCode.
Change-Id: I8a79b0245cb5d4349aa375e6503bcc5bec3b72a3
---
M be/src/common/status.cc
M be/src/common/status.h
M be/src/runtime/krpc-data-stream-sender.cc
M be/src/runtime/query-state.cc
M be/src/runtime/query-state.h
M be/src/service/client-request-state.cc
M be/src/util/container-util.h
M be/src/util/error-util.h
M common/protobuf/common.proto
M common/thrift/Status.thrift
M common/thrift/generate_error_codes.py
11 files changed, 138 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/14882/2
--
To view, visit http://gerrit.cloudera.org:8080/14882
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8a79b0245cb5d4349aa375e6503bcc5bec3b72a3
Gerrit-Change-Number: 14882
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Sahil Takiar <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
