Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14882 )
Change subject: IMPALA-9138: Classify certain errors as retryable ...................................................................... Patch Set 2: Updated patch addressing Thomas' comments. The most straightforward approach I could find was to make a dedicated MergeStatusProperties method in Status, and use that method on the overall_status tracked in QueryState. I decided to separate it out from MergeStatus because MergeStatus combines all the error message details of the two Status objects. If there are lot of failed fragment instances, the overall_status object could potentially get very large. The only caveat is that overall_status is not idempotent. So it could initially be retryable, and then a later report could set it to non-retryable. Transparent query retries will have to be careful to wait for all fragment instances to complete before reading the properties of the overall_status. -- To view, visit http://gerrit.cloudera.org:8080/14882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a79b0245cb5d4349aa375e6503bcc5bec3b72a3 Gerrit-Change-Number: 14882 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Thu, 12 Dec 2019 23:35:29 +0000 Gerrit-HasComments: No
