Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp. ...................................................................... Patch Set 1: (2 comments) Thanks for sending this patch! This seems good in overall, however I also miss the test coverage. http://gerrit.cloudera.org:8080/#/c/14896/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java File fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java: http://gerrit.cloudera.org:8080/#/c/14896/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java@56 PS1, Line 56: simplified nit: simplified_expr would be a more verbose name http://gerrit.cloudera.org:8080/#/c/14896/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java@58 PS1, Line 58: isStringType As far as I know this includes char arrays as well. Those introduce one more step in the conversion for char[n] -> string. Have you tried testing with this type as well? -- To view, visit http://gerrit.cloudera.org:8080/14896 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d Gerrit-Change-Number: 14896 Gerrit-PatchSet: 1 Gerrit-Owner: Zhou Xu <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 13 Dec 2019 15:38:09 +0000 Gerrit-HasComments: Yes
