Zhou Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14896/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java File fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java: http://gerrit.cloudera.org:8080/#/c/14896/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java@40 PS1, Line 40: SimplifyCastStringToTimestamp > Please add some tests to ExprRewriteRulesTest.java Done -- To view, visit http://gerrit.cloudera.org:8080/14896 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d Gerrit-Change-Number: 14896 Gerrit-PatchSet: 2 Gerrit-Owner: Zhou Xu <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zhou Xu <[email protected]> Gerrit-Comment-Date: Tue, 17 Dec 2019 10:44:24 +0000 Gerrit-HasComments: Yes
