Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14904 )
Change subject: IMPALA-9231: support simplified privilege checks for SHOW DATABASES ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14904/1/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/14904/1/be/src/common/global-flags.cc@282 PS1, Line 282: false I think its rare that users who have insert (or other privileges) do not have select privileges. So a boolean value would work for most of the users. However, in the rare case that an environment has some users who do not have select privileges, the show command will not list the dbs and tables. Can we change the type of this configuration to a stringset (set of allowed string values)? I propose we should allow SELECT, INSERT, ANY for now so that we cover all the usecases. Any thoughts? -- To view, visit http://gerrit.cloudera.org:8080/14904 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I631fc5c386a52f0a1f62182473be15fcc3dd8609 Gerrit-Change-Number: 14904 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Fri, 13 Dec 2019 18:05:12 +0000 Gerrit-HasComments: Yes
