Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14904 )
Change subject: IMPALA-9231: support simplified privilege checks for SHOW DATABASES ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/14904/1/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/14904/1/be/src/common/global-flags.cc@282 PS1, Line 282: > I think its rare that users who have insert (or other privileges) do not ha Good point. I change it to a set to accept customized privilege set to check. http://gerrit.cloudera.org:8080/#/c/14904/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/14904/1/fe/src/main/java/org/apache/impala/service/Frontend.java@943 PS1, Line 943: // have permissions on. : if (authzFactory_.getAuthorizationConfig().isEnabled()) { : Iterator<? extends FeDb> iter = dbs.iterator(); : > There could be a function for this like RequiredPrivilegeForShowDbsAndTable Done http://gerrit.cloudera.org:8080/#/c/14904/1/tests/authorization/test_authorization.py File tests/authorization/test_authorization.py: http://gerrit.cloudera.org:8080/#/c/14904/1/tests/authorization/test_authorization.py@547 PS1, Line 547: self.client.execute("drop database if exists %s cascade" % unique_db) > nit: +2 indentation Done http://gerrit.cloudera.org:8080/#/c/14904/1/tests/authorization/test_authorization.py@557 PS1, Line 557: "--visibility_privilege_set=select" % > nit: +2 indentation Done http://gerrit.cloudera.org:8080/#/c/14904/1/tests/authorization/test_authorization.py@597 PS1, Line 597: catalogd_args="--sentry_config={0}".format(SENTRY_CONFIG_FILE), > nit: +2 indentation Done -- To view, visit http://gerrit.cloudera.org:8080/14904 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I631fc5c386a52f0a1f62182473be15fcc3dd8609 Gerrit-Change-Number: 14904 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Wed, 18 Dec 2019 03:33:01 +0000 Gerrit-HasComments: Yes
