Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14885 )
Change subject: IMPALA-8891: Fix non-standard null handling in concat_ws() ...................................................................... Patch Set 9: Code-Review+1 (1 comment) LGTM. Thanks for addressing these! I left one nit comment about the code style. Give +1 first if Csaba wants to take a look too. http://gerrit.cloudera.org:8080/#/c/14885/9/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/14885/9/be/src/exprs/string-functions-ir.cc@871 PS9, Line 871: if (total_size <= 0){ : return StringVal(); : } We wrap this into one line if the whole line fits into the 90 character limit: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65868536#C++StyleGuide-Formatting if (total_size <= 0) return StringVal(); -- To view, visit http://gerrit.cloudera.org:8080/14885 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64cd3bfbb952e431a0cf52a5835ac05d2513d29b Gerrit-Change-Number: 14885 Gerrit-PatchSet: 9 Gerrit-Owner: jichen <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: jichen <[email protected]> Gerrit-Comment-Date: Mon, 16 Dec 2019 01:44:16 +0000 Gerrit-HasComments: Yes
