Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14885 )
Change subject: IMPALA-8891: Fix non-standard null handling in concat_ws() ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/14885/11/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/14885/11/be/src/exprs/string-functions-ir.cc@918 PS11, Line 918: DCHECK_GT(valid_num_children, 0); This should be moved to before the if-clause since we used to check it in the if-clause. You can put it right after the for-loop. -- To view, visit http://gerrit.cloudera.org:8080/14885 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64cd3bfbb952e431a0cf52a5835ac05d2513d29b Gerrit-Change-Number: 14885 Gerrit-PatchSet: 11 Gerrit-Owner: jichen <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: jichen <[email protected]> Gerrit-Comment-Date: Tue, 17 Dec 2019 02:27:30 +0000 Gerrit-HasComments: Yes
