Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14941 )
Change subject: IMPALA-4192: Move static state from DataSink into a DataSinkConfig ...................................................................... Patch Set 1: Code-Review+2 (9 comments) I have a bunch of very minor nits, but LGTM http://gerrit.cloudera.org:8080/#/c/14941/1/be/src/exec/data-sink.h File be/src/exec/data-sink.h: http://gerrit.cloudera.org:8080/#/c/14941/1/be/src/exec/data-sink.h@51 PS1, Line 51: nit: unnecessary blank line http://gerrit.cloudera.org:8080/#/c/14941/1/be/src/exec/data-sink.h@66 PS1, Line 66: /// Pointer to the thrift data sink struct associated with this sink. nit: is this always initialised to non-null in Init()? http://gerrit.cloudera.org:8080/#/c/14941/1/be/src/exec/data-sink.h@71 PS1, Line 71: const RowDescriptor* input_row_desc_ = nullptr; nit: is this always initialised to non-null in Init()? http://gerrit.cloudera.org:8080/#/c/14941/1/be/src/exec/partitioned-hash-join-builder.h File be/src/exec/partitioned-hash-join-builder.h: http://gerrit.cloudera.org:8080/#/c/14941/1/be/src/exec/partitioned-hash-join-builder.h@44 PS1, Line 44: /// Partitioned Hash Join Builder Config class. This has a few extra methods to be used I'm gonna have fun rebasing my change onto this :) http://gerrit.cloudera.org:8080/#/c/14941/1/be/src/exec/partitioned-hash-join-builder.h@48 PS1, Line 48: nit: blank line http://gerrit.cloudera.org:8080/#/c/14941/1/be/src/exec/partitioned-hash-join-builder.h@51 PS1, Line 51: nit: blank line http://gerrit.cloudera.org:8080/#/c/14941/1/be/src/exec/partitioned-hash-join-builder.h@53 PS1, Line 53: virtual Status Init(const TDataSink& tsink, const RowDescriptor* input_row_desc, nit: the virtual isn't really needed along with the override. Not a big deal, the pattern is all over the codebase, but someone pointed out that it was redundant a while back. http://gerrit.cloudera.org:8080/#/c/14941/1/be/src/runtime/fragment-instance-state.cc File be/src/runtime/fragment-instance-state.cc: http://gerrit.cloudera.org:8080/#/c/14941/1/be/src/runtime/fragment-instance-state.cc@220 PS1, Line 220: DataSinkConfig::CreateConfig( Any reason not to pass in sink_config_ directly? http://gerrit.cloudera.org:8080/#/c/14941/1/be/src/runtime/krpc-data-stream-sender.h File be/src/runtime/krpc-data-stream-sender.h: http://gerrit.cloudera.org:8080/#/c/14941/1/be/src/runtime/krpc-data-stream-sender.h@44 PS1, Line 44: virtual Status Init(const TDataSink& tsink, const RowDescriptor* input_row_desc, same comment as before about the virtual/override redundancy. -- To view, visit http://gerrit.cloudera.org:8080/14941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d5b4226f6cec5305b0ec9a25c5f18b5521c8dd2 Gerrit-Change-Number: 14941 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sun, 22 Dec 2019 08:52:22 +0000 Gerrit-HasComments: Yes
