Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14941 )
Change subject: IMPALA-4192: Move static state from DataSink into a DataSinkConfig ...................................................................... Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/14941/2/be/src/exec/data-sink.h File be/src/exec/data-sink.h: http://gerrit.cloudera.org:8080/#/c/14941/2/be/src/exec/data-sink.h@54 PS2, Line 54: ; no ; needed (this seems to a problem for clang tidy too) http://gerrit.cloudera.org:8080/#/c/14941/2/be/src/exec/hbase-table-sink.h File be/src/exec/hbase-table-sink.h: http://gerrit.cloudera.org:8080/#/c/14941/2/be/src/exec/hbase-table-sink.h@40 PS2, Line 40: ~HBaseTableSinkConfig() {} please add override http://gerrit.cloudera.org:8080/#/c/14941/2/be/src/exec/kudu-table-sink.h File be/src/exec/kudu-table-sink.h: http://gerrit.cloudera.org:8080/#/c/14941/2/be/src/exec/kudu-table-sink.h@39 PS2, Line 39: ~KuduTableSinkConfig() {} please add override http://gerrit.cloudera.org:8080/#/c/14941/2/be/src/exec/nested-loop-join-builder.h File be/src/exec/nested-loop-join-builder.h: http://gerrit.cloudera.org:8080/#/c/14941/2/be/src/exec/nested-loop-join-builder.h@39 PS2, Line 39: ~NljBuilderConfig() {} please add override http://gerrit.cloudera.org:8080/#/c/14941/2/be/src/exec/partitioned-hash-join-builder.h File be/src/exec/partitioned-hash-join-builder.h: http://gerrit.cloudera.org:8080/#/c/14941/2/be/src/exec/partitioned-hash-join-builder.h@67 PS2, Line 67: ~PhjBuilderConfig() {} please add override http://gerrit.cloudera.org:8080/#/c/14941/2/be/src/exec/plan-root-sink.h File be/src/exec/plan-root-sink.h: http://gerrit.cloudera.org:8080/#/c/14941/2/be/src/exec/plan-root-sink.h@36 PS2, Line 36: ~PlanRootSinkConfig() {} please add override http://gerrit.cloudera.org:8080/#/c/14941/2/be/src/runtime/krpc-data-stream-sender.h File be/src/runtime/krpc-data-stream-sender.h: http://gerrit.cloudera.org:8080/#/c/14941/2/be/src/runtime/krpc-data-stream-sender.h@52 PS2, Line 52: ~KrpcDataStreamSenderConfig() {} please add override -- To view, visit http://gerrit.cloudera.org:8080/14941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d5b4226f6cec5305b0ec9a25c5f18b5521c8dd2 Gerrit-Change-Number: 14941 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 08 Jan 2020 12:42:02 +0000 Gerrit-HasComments: Yes
