wangsheng has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14319 )

Change subject: IMPALA-8984: Fix race condition in creating Kudu table
......................................................................


Patch Set 16:

> (4 comments)
 >
 > The fix makes sense to me. But it'd be better if we can pass the
 > test_concurrent_create_kudu_table test I pasted below, since we are
 > fixing race condition in creating the same kudu table in parallel.

Hi Quanlong, thanks for your kind advice, I've already add a custom cluster 
test case to reproduce this bug by many iterations and some time sleep.
Besides, I hit another bug when testing, so I use a 'kuduDdlLock_' when create 
kudu managed table in KuduCatalogOpExecutor.createManagedTable. And I submit an 
exhaustive test, all test cases passed, here is the jenkins url: 
https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/9413/


--
To view, visit http://gerrit.cloudera.org:8080/14319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a4047bcdaa6b346765b96e8c36bb747a2b0091d
Gerrit-Change-Number: 14319
Gerrit-PatchSet: 16
Gerrit-Owner: wangsheng <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Reviewer: wangsheng <[email protected]>
Gerrit-Comment-Date: Fri, 27 Dec 2019 02:51:16 +0000
Gerrit-HasComments: No

Reply via email to