Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14319 )
Change subject: IMPALA-8984: Fix race condition in creating Kudu table ...................................................................... Patch Set 17: (1 comment) Thanks for keep updating the patch! The patch looks good to me overall except a question in the test. http://gerrit.cloudera.org:8080/#/c/14319/17/tests/custom_cluster/test_concurrent_kudu_create.py File tests/custom_cluster/test_concurrent_kudu_create.py: http://gerrit.cloudera.org:8080/#/c/14319/17/tests/custom_cluster/test_concurrent_kudu_create.py@55 PS17, Line 55: time.sleep(0.5) Could you add a comment for the sleep? It's still not quite clear for me... Doesn't it reduce the possibility for race condition? -- To view, visit http://gerrit.cloudera.org:8080/14319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a4047bcdaa6b346765b96e8c36bb747a2b0091d Gerrit-Change-Number: 14319 Gerrit-PatchSet: 17 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Sat, 28 Dec 2019 02:06:36 +0000 Gerrit-HasComments: Yes
