Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14894 )
Change subject: IMPALA-9009: Core support for Ranger column masking ...................................................................... Patch Set 11: (1 comment) Hi Quanlong, I have only one minor comment after reading AuthorizationStmtTest.java. Will keep reading other test related files and let you know if I have any additional suggestion. Thanks! http://gerrit.cloudera.org:8080/#/c/14894/11/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/14894/11/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@2918 PS11, Line 2918: .ok(onServer(TPrivilegeLevel.ALL)) I was wondering if it would be good to also exercise the code path for this test statement as well as the following ones when the authorization fails. For example, we could do this by not granting any privilege, i.e., 'ok()', or granting a privilege that is insufficient to pass the authorization, e.g., 'ok(onServer(TPrivilegeLevel.REFRESH))'. On the other hand, I also found that any server-wide privilege other than 'TPrivilegeLevel.ALL' and 'TPrivilegeLevel.OWNER' is insufficient to pass the authorization for the query above, although I am not very sure if this is also an expected behavior. -- To view, visit http://gerrit.cloudera.org:8080/14894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4cad60e0e69ea573b7ecfc011b142c46ef52ed61 Gerrit-Change-Number: 14894 Gerrit-PatchSet: 11 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 31 Dec 2019 00:44:06 +0000 Gerrit-HasComments: Yes
