Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14894 )
Change subject: IMPALA-9009: Core support for Ranger column masking ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/14894/12/fe/src/main/java/org/apache/impala/analysis/TableRef.java File fe/src/main/java/org/apache/impala/analysis/TableRef.java: http://gerrit.cloudera.org:8080/#/c/14894/12/fe/src/main/java/org/apache/impala/analysis/TableRef.java@27 PS12, Line 27: import java.util.UUID; Is this needed? Don't see it getting used anywhere in the diffs. http://gerrit.cloudera.org:8080/#/c/14894/12/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/14894/12/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@283 PS12, Line 283: maskType Do we need to add Preconditions here to check if maskType and maskTypeDef are not null? http://gerrit.cloudera.org:8080/#/c/14894/12/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@290 PS12, Line 290: mask Curious to understand: Do these masks work as UDFs? How are they loaded? -- To view, visit http://gerrit.cloudera.org:8080/14894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4cad60e0e69ea573b7ecfc011b142c46ef52ed61 Gerrit-Change-Number: 14894 Gerrit-PatchSet: 11 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Mon, 06 Jan 2020 21:38:57 +0000 Gerrit-HasComments: Yes
