Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14973 )
Change subject: IMPALA-9274: cyclic barrier implementation ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14973/4/be/src/util/cyclic-barrier.h File be/src/util/cyclic-barrier.h: http://gerrit.cloudera.org:8080/#/c/14973/4/be/src/util/cyclic-barrier.h@61 PS4, Line 61: barrier_cv_.NotifyAll(); Shouldn't this (+ the same call in Cancel()) happen while we hold the lock? Cancel can be called just before this statement, leading to return with Ok on this thread after Cancel() + possibly some other threads returned with error. I don't know whether this can cause problems in the future usage of this class. pthread_cond_broadcast can be called both with our without holding the lock according to https://linux.die.net/man/3/pthread_cond_broadcast -- To view, visit http://gerrit.cloudera.org:8080/14973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5c8cc6b3023d2dc03c8116d462440c5e25c3bb0 Gerrit-Change-Number: 14973 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 06 Jan 2020 16:20:29 +0000 Gerrit-HasComments: Yes
