Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14973 )
Change subject: IMPALA-9274: cyclic barrier implementation ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14973/4/be/src/util/cyclic-barrier.h File be/src/util/cyclic-barrier.h: http://gerrit.cloudera.org:8080/#/c/14973/4/be/src/util/cyclic-barrier.h@61 PS4, Line 61: barrier_cv_.NotifyAll(); > I see now (actually I don't know why I thought that it would make a differe FWIW it's not perf critical in the initial application I have in mind - it would be invoked once for each non-spilling broadcast hash join, and once per set of in-memory hash tables for the spilling hash join (where it's going to be a lot cheaper than reading data from disk and building the hash tables.). -- To view, visit http://gerrit.cloudera.org:8080/14973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5c8cc6b3023d2dc03c8116d462440c5e25c3bb0 Gerrit-Change-Number: 14973 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 08 Jan 2020 03:13:12 +0000 Gerrit-HasComments: Yes
