Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14894 )
Change subject: IMPALA-9009: Core support for Ranger column masking ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/14894/12/testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test File testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test: http://gerrit.cloudera.org:8080/#/c/14894/12/testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test@261 PS12, Line 261: Should not mask the columns when used in sql generations I am a bit confused by this comment. Does that mean after creating the view 'masked_view' and executing a SQL statement like "select id, bool_col, string_col from masked_view", the values in the columns of 'id', 'bool_col', and 'string_col' should not be masked? I have manually tested this in my local dev environment but have got the following results after executing "select id, bool_col, string_col from masked_view". +-----+----------+------------+ | id | bool_col | string_col | +-----+----------+------------+ | 0 | NULL | 0aaa | | 100 | NULL | 1aaa | | 200 | NULL | 0aaa | | 300 | NULL | 1aaa | | 400 | NULL | 0aaa | | 500 | NULL | 1aaa | | 600 | NULL | 0aaa | | 700 | NULL | 1aaa | +-----+----------+------------+ According to the returned results, the values in those 3 columns are actually masked/transformed. Maybe I misunderstand the comment at the beginning of this test. -- To view, visit http://gerrit.cloudera.org:8080/14894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4cad60e0e69ea573b7ecfc011b142c46ef52ed61 Gerrit-Change-Number: 14894 Gerrit-PatchSet: 12 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 07 Jan 2020 00:56:32 +0000 Gerrit-HasComments: Yes
