Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14991 )
Change subject: IMPALA-9267: Fix DCHECK in ClientRequestState::UpdateNonErrorExecState ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14991/1/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/14991/1/be/src/service/client-request-state.cc@955 PS1, Line 955: if (old_state == ExecState::ERROR) { Do you have this backwards? As written, won't this transition to FINISHED only if it was already ERROR? -- To view, visit http://gerrit.cloudera.org:8080/14991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie47444ed67704d9469310727eeec2e9a66516e77 Gerrit-Change-Number: 14991 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Wed, 08 Jan 2020 22:05:48 +0000 Gerrit-HasComments: Yes
