Sahil Takiar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14991 )
Change subject: IMPALA-9267: Fix DCHECK in ClientRequestState::UpdateNonErrorExecState ...................................................................... IMPALA-9267: Fix DCHECK in ClientRequestState::UpdateNonErrorExecState Fixes a DCHECK in ClientRequestState::UpdateNonErrorExecState where the ClientRequestState ExecState attempts to transition from the ERROR to the FINISHED state. The DCHECK was added in IMPALA-6894 in order to prevent any invalid state transition attempts. The fix is to modify UpdateNonErrorExecState so that it skips any attempt to transition from the ERROR to the FINISHED state, which is in line with the behavior prior to IMPALA-6894. Testing: * Ran core tests, unable to reproduce the original issue locally Change-Id: Ie47444ed67704d9469310727eeec2e9a66516e77 Reviewed-on: http://gerrit.cloudera.org:8080/14991 Reviewed-by: Thomas Tauber-Marshall <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/service/client-request-state.cc M be/src/service/client-request-state.h 2 files changed, 21 insertions(+), 12 deletions(-) Approvals: Thomas Tauber-Marshall: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/14991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie47444ed67704d9469310727eeec2e9a66516e77 Gerrit-Change-Number: 14991 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
