Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14894 )
Change subject: IMPALA-9009: Core support for Ranger column masking ...................................................................... Patch Set 15: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/14894/15/fe/src/main/java/org/apache/impala/analysis/FromClause.java File fe/src/main/java/org/apache/impala/analysis/FromClause.java: http://gerrit.cloudera.org:8080/#/c/14894/15/fe/src/main/java/org/apache/impala/analysis/FromClause.java@126 PS15, Line 126: get(i++).reset() beautification: I would prefer to move this to the end of the loop, as "dirty for expressions" do not seem to be common in Impala. Continues could be replaced with returns by creating a function like unmaskAndUnresolveTableRef(int i). It could be also mentioned in a comment that that the recursion happens here for views. -- To view, visit http://gerrit.cloudera.org:8080/14894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4cad60e0e69ea573b7ecfc011b142c46ef52ed61 Gerrit-Change-Number: 14894 Gerrit-PatchSet: 15 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Fri, 10 Jan 2020 17:50:21 +0000 Gerrit-HasComments: Yes
