Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/14894 )
Change subject: IMPALA-9009: Core support for Ranger column masking ...................................................................... Patch Set 16: (4 comments) Mostly concerned if adding the inline view is necessary and whether that precludes other optimizations. http://gerrit.cloudera.org:8080/#/c/14894/16/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/14894/16/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@760 PS16, Line 760: resolvedTableRef = new InlineViewRef((FeView) table, tableRef); Does adding this view boundary preclude any subsequent optimizations such as predicates being pushed down to the table? http://gerrit.cloudera.org:8080/#/c/14894/16/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@771 PS16, Line 771: return resolvedTableRef; Should BaseTableRef be returned in this case as before? http://gerrit.cloudera.org:8080/#/c/14894/16/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationFactory.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationFactory.java: http://gerrit.cloudera.org:8080/#/c/14894/16/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationFactory.java@104 PS16, Line 104: public boolean supportsColumnMaskingAndRowFiltering() { We still don't support row filtering.. http://gerrit.cloudera.org:8080/#/c/14894/16/fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java File fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java: http://gerrit.cloudera.org:8080/#/c/14894/16/fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java@249 PS16, Line 249: authzChecker_ = new RangerAuthorizationCheckerSpy(authzConfig_); Any synchronizationb needed here? -- To view, visit http://gerrit.cloudera.org:8080/14894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4cad60e0e69ea573b7ecfc011b142c46ef52ed61 Gerrit-Change-Number: 14894 Gerrit-PatchSet: 16 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Mon, 13 Jan 2020 19:30:57 +0000 Gerrit-HasComments: Yes
