Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15046 )
Change subject: IMPALA-9296: Move AuxErrorInfo to StatefulStatus ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15046/1/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: http://gerrit.cloudera.org:8080/#/c/15046/1/be/src/runtime/runtime-state.h@322 PS1, Line 322: This method clears aux_error_info_ > Hmm, I guess I didn't realize this wasn't already the case before this patc I don't full understand how the protocol works, but it looks like after a certain point FragmentInstanceExecStatusPB are no longer sent. I believe once they are marked as 'done', they said a final report and then thats it. So the issue I was seeing in IMPALA-9295 was that the final fragment report include the aux error info, but the overall status report didn't have an overall_status set. http://gerrit.cloudera.org:8080/#/c/15046/1/be/src/runtime/runtime-state.h@446 PS1, Line 446: bool reported_aux_error_info_; > Might want to explicitly initialize this to false here for clarity. Done http://gerrit.cloudera.org:8080/#/c/15046/1/be/src/runtime/runtime-state.cc File be/src/runtime/runtime-state.cc: http://gerrit.cloudera.org:8080/#/c/15046/1/be/src/runtime/runtime-state.cc@316 PS1, Line 316: if (aux_error_info_ == nullptr && !reported_aux_error_info_) { > I'm not sure that this is the right was to do it, since it means that if a I agree this is a good idea. I think we should do it in a follow up JIRA though. Filed IMPALA-9301. -- To view, visit http://gerrit.cloudera.org:8080/15046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabbb48dd3ab58ba7b76b1ab6979b92d0e25e72e3 Gerrit-Change-Number: 15046 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Thu, 16 Jan 2020 21:15:20 +0000 Gerrit-HasComments: Yes
