Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15046 )
Change subject: IMPALA-9296: Move AuxErrorInfo to StatefulStatus ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/15046/1/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: http://gerrit.cloudera.org:8080/#/c/15046/1/be/src/runtime/runtime-state.h@322 PS1, Line 322: This method clears aux_error_info_ > I don't full understand how the protocol works, but it looks like after a c Alright, well like I said I think this is the right approach anyways. http://gerrit.cloudera.org:8080/#/c/15046/1/be/src/runtime/runtime-state.cc File be/src/runtime/runtime-state.cc: http://gerrit.cloudera.org:8080/#/c/15046/1/be/src/runtime/runtime-state.cc@316 PS1, Line 316: if (aux_error_info_ == nullptr && !reported_aux_error_info_) { > I agree this is a good idea. I think we should do it in a follow up JIRA th Sounds good. Probably doesn't need to be done before the main transparent query retry patch -- To view, visit http://gerrit.cloudera.org:8080/15046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabbb48dd3ab58ba7b76b1ab6979b92d0e25e72e3 Gerrit-Change-Number: 15046 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Thu, 16 Jan 2020 23:27:19 +0000 Gerrit-HasComments: Yes
