Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15050 )
Change subject: IMPALA-9291: MemTracker's TryConsume() should behave consistent with Consume()/Release() ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15050/1/be/src/runtime/mem-tracker.h File be/src/runtime/mem-tracker.h: http://gerrit.cloudera.org:8080/#/c/15050/1/be/src/runtime/mem-tracker.h@171 PS1, Line 171: DCHECK_GE(bytes, 0); : DCHECK(!closed_) << label_; : if (consumption_metric_ != nullptr) RefreshConsumptionFromMetric(); : if (UNLIKELY(bytes == 0)) return true; > I'd consider removing the bytes == 0 special case, since it's not common so Added checks for the bytes < 0 case and return false in TryConsume(). Unfortunately Consume() and Release() don't have return values. http://gerrit.cloudera.org:8080/#/c/15050/1/be/src/runtime/mem-tracker.h@215 PS1, Line 215: if (bytes == 0) return; > Same here - consider removing the special case. Removed the check against 0, but Based on Csaba's suggestion I changed it to check if bytes < 0. -- To view, visit http://gerrit.cloudera.org:8080/15050 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22e613c49e4a6bd218e7f7f7c0d6bec95b75cff5 Gerrit-Change-Number: 15050 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 17 Jan 2020 10:40:15 +0000 Gerrit-HasComments: Yes
