Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15050 )
Change subject: IMPALA-9291: MemTracker's TryConsume() should behave consistent with Consume()/Release() ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/15050/1/be/src/runtime/mem-tracker.h File be/src/runtime/mem-tracker.h: http://gerrit.cloudera.org:8080/#/c/15050/1/be/src/runtime/mem-tracker.h@171 PS1, Line 171: WARN_UNUSED_RESULT : bool TryConsume(int64_t bytes, MemLimit mode = MemLimit::HARD) { : DCHECK_GE(bytes, 0); : DCHECK(!closed_) << label_; > Added checks for the bytes < 0 case and return false in TryConsume(). Unfor nit: a comment like " // needed in RELEASE, hits DCHECK in DEBUG" would make the intention clearer (+ would still fit in 90 chars) -- To view, visit http://gerrit.cloudera.org:8080/15050 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22e613c49e4a6bd218e7f7f7c0d6bec95b75cff5 Gerrit-Change-Number: 15050 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 17 Jan 2020 14:08:56 +0000 Gerrit-HasComments: Yes
