Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15026 )
Change subject: IMPALA-9068: Use different directories for external vs managed warehouse ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/15026/3/testdata/avro_schema_resolution/create_table.sql File testdata/avro_schema_resolution/create_table.sql: http://gerrit.cloudera.org:8080/#/c/15026/3/testdata/avro_schema_resolution/create_table.sql@47 PS3, Line 47: LOCATION '/test-warehouse/avro_schema_resolution_test/'; can we add something to hiveconf like 'warehouse.dir' that is either set to 'hive.metastore.warehouse.external.dir' for Hive 3 and 'hive.metastore.warehouse.dir' for Hive 2? Or maybe we can add 'hive.metastore.warehouse.external.dir' in the Hive 2 configs? That way we don't have to hardcode the `/test-warehouse/` path http://gerrit.cloudera.org:8080/#/c/15026/3/testdata/bin/load_nested.py File testdata/bin/load_nested.py: http://gerrit.cloudera.org:8080/#/c/15026/3/testdata/bin/load_nested.py@92 PS3, Line 92: external.table.purge'='TRUE' whats this for? http://gerrit.cloudera.org:8080/#/c/15026/3/testdata/cluster/node_templates/cdh7/etc/init.d/kms File testdata/cluster/node_templates/cdh7/etc/init.d/kms: http://gerrit.cloudera.org:8080/#/c/15026/3/testdata/cluster/node_templates/cdh7/etc/init.d/kms@1 PS3, Line 1: #!/bin/bash is this the same as testdata/cluster/node_templates/cdh6/etc/init.d/kms ? can it just be symlinked? http://gerrit.cloudera.org:8080/#/c/15026/3/tests/custom_cluster/test_hive_parquet_codec_interop.py File tests/custom_cluster/test_hive_parquet_codec_interop.py: http://gerrit.cloudera.org:8080/#/c/15026/3/tests/custom_cluster/test_hive_parquet_codec_interop.py@87 PS3, Line 87: external does it matter this change is being made for Hive 2 as well? -- To view, visit http://gerrit.cloudera.org:8080/15026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3db69f1b8ca07ae98670429954f5f7a1a359eaec Gerrit-Change-Number: 15026 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Fri, 17 Jan 2020 21:22:51 +0000 Gerrit-HasComments: Yes
