Sahil Takiar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15026 )

Change subject: IMPALA-9068: Use different directories for external vs managed 
warehouse
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

LGTM. Can upgrade to +2 after the new patch is uploaded.

http://gerrit.cloudera.org:8080/#/c/15026/3/testdata/avro_schema_resolution/create_table.sql
File testdata/avro_schema_resolution/create_table.sql:

http://gerrit.cloudera.org:8080/#/c/15026/3/testdata/avro_schema_resolution/create_table.sql@47
PS3, Line 47: LOCATION '/test-warehouse/avro_schema_resolution_test/';
> My thought on this is that this is one of the few places that tries to be g
Fine with me.


http://gerrit.cloudera.org:8080/#/c/15026/3/testdata/bin/load_nested.py
File testdata/bin/load_nested.py:

http://gerrit.cloudera.org:8080/#/c/15026/3/testdata/bin/load_nested.py@92
PS3, Line 92: external.table.purge'='TRUE'
> Hive has a CTAS bug (HIVE-22371) where it puts data in the wrong directory
Makes sense.



--
To view, visit http://gerrit.cloudera.org:8080/15026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3db69f1b8ca07ae98670429954f5f7a1a359eaec
Gerrit-Change-Number: 15026
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Sahil Takiar <[email protected]>
Gerrit-Comment-Date: Thu, 23 Jan 2020 15:40:50 +0000
Gerrit-HasComments: Yes

Reply via email to