Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15062 )
Change subject: [WIP] IMPALA-6772: Enable test_scanners_fuzz for ORC ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15062/2/tests/query_test/test_scanners_fuzz.py File tests/query_test/test_scanners_fuzz.py: http://gerrit.cloudera.org:8080/#/c/15062/2/tests/query_test/test_scanners_fuzz.py@281 PS2, Line 281: if rng.random() < 0.4: : truncation = rng.randint(0, len(data)) : LOG.info("corrupt file: Truncate {0} to {1}".format(path, truncation)) : data = data[:truncation] For footer-based file formats it deletes the metadata making the whole file unreadable. Most likely the reader will fail during the magic bytes check, so it doesn't add much coverage there. Maybe we could delete parts from the front (but it will also just cause failures during magic bytes checking). I think the best would be to delete random parts of the file. -- To view, visit http://gerrit.cloudera.org:8080/15062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3233e5d9f555029d954b5ddd5858ea194afc06bf Gerrit-Change-Number: 15062 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 20 Jan 2020 14:22:42 +0000 Gerrit-HasComments: Yes
