Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15062 )
Change subject: [WIP] IMPALA-6772: Enable test_scanners_fuzz for ORC ...................................................................... Patch Set 3: (2 comments) Thanks for applying the changes http://gerrit.cloudera.org:8080/#/c/15062/3/tests/query_test/test_scanners_fuzz.py File tests/query_test/test_scanners_fuzz.py: http://gerrit.cloudera.org:8080/#/c/15062/3/tests/query_test/test_scanners_fuzz.py@281 PS3, Line 281: 0 wrong index, should be 2 http://gerrit.cloudera.org:8080/#/c/15062/3/tests/query_test/test_scanners_fuzz.py@282 PS3, Line 282: data = data[:beg] + data[end:] This might involve a lot of copying. Maybe with open(path, "wb") as f: f.write(data[:beg]) f.write(data[end:]) would be more efficient and would also require less memory. -- To view, visit http://gerrit.cloudera.org:8080/15062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3233e5d9f555029d954b5ddd5858ea194afc06bf Gerrit-Change-Number: 15062 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 21 Jan 2020 10:29:20 +0000 Gerrit-HasComments: Yes
