Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15050 )
Change subject: IMPALA-9291: MemTracker's TryConsume() should behave consistent with Consume()/Release() ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15050/1/be/src/runtime/mem-tracker.h File be/src/runtime/mem-tracker.h: http://gerrit.cloudera.org:8080/#/c/15050/1/be/src/runtime/mem-tracker.h@215 PS1, Line 215: if (bytes == 0) return; > Removed the check against 0, but Based on Csaba's suggestion I changed it t Based on the backend tests when Consume()/Release() is called with 0 as argument it shouldn't update 'consumption_' even when 'consumption_metric_' is not null. TryConsume() also behaved differently in this regard so I also resolved that inconsistency. -- To view, visit http://gerrit.cloudera.org:8080/15050 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22e613c49e4a6bd218e7f7f7c0d6bec95b75cff5 Gerrit-Change-Number: 15050 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 22 Jan 2020 13:50:31 +0000 Gerrit-HasComments: Yes
