Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15104 )
Change subject: IMPALA-9228: ORC scanner reads rows into scratch batch ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15104/1/be/src/exec/hdfs-orc-scanner.cc File be/src/exec/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/15104/1/be/src/exec/hdfs-orc-scanner.cc@693 PS1, Line 693: // TODO kaszab: call EvalConjuncts on rows in scratch_batch before incrementiong row_id line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/15104/1/be/src/exec/orc-column-readers.h File be/src/exec/orc-column-readers.h: http://gerrit.cloudera.org:8080/#/c/15104/1/be/src/exec/orc-column-readers.h@181 PS1, Line 181: // Params of GetValueBatch(): int max_values, int tuple_size, uint8_t* RESTRICT tuple_mem, int* RESTRICT num_values line too long (121 > 90) -- To view, visit http://gerrit.cloudera.org:8080/15104 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56db0325dee283d73742ebbae412d19693fac0ca Gerrit-Change-Number: 15104 Gerrit-PatchSet: 1 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 24 Jan 2020 10:37:01 +0000 Gerrit-HasComments: Yes
