Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15104 )
Change subject: IMPALA-9228: ORC scanner reads rows into scratch batch ...................................................................... Patch Set 5: Code-Review+1 (3 comments) Only found nits, other than that LGTM http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/hdfs-scanner.h File be/src/exec/hdfs-scanner.h: http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/hdfs-scanner.h@a566 PS5, Line 566: : : : : nit: maybe these could be moved together to public. http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/orc-column-readers.h File be/src/exec/orc-column-readers.h: http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/orc-column-readers.h@188 PS5, Line 188: friend class OrcPrimitiveColumnReader<OrcBoolColumnReader>; Since ReadValue() is public I think you don't need the friend declarations anymore. http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/orc-column-readers.cc File be/src/exec/orc-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/orc-column-readers.cc@221 PS5, Line 221: Status OrcDecimal16ColumnReader::ReadValue(int row_idx, Tuple* tuple, : MemPool* pool) { nit: fits single line again -- To view, visit http://gerrit.cloudera.org:8080/15104 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56db0325dee283d73742ebbae412d19693fac0ca Gerrit-Change-Number: 15104 Gerrit-PatchSet: 5 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 02 Mar 2020 12:55:26 +0000 Gerrit-HasComments: Yes
