Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14705 )
Change subject: IMPALA-8800: Added support of Kudu DATE type to Impala ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/14705/8/fe/src/main/java/org/apache/impala/util/KuduUtil.java File fe/src/main/java/org/apache/impala/util/KuduUtil.java: http://gerrit.cloudera.org:8080/#/c/14705/8/fe/src/main/java/org/apache/impala/util/KuduUtil.java@387 PS8, Line 387: isSupportedKeyType Date should be added here. See my comment in kudu_create.test http://gerrit.cloudera.org:8080/#/c/14705/8/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test: http://gerrit.cloudera.org:8080/#/c/14705/8/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test@363 PS8, Line 363: Unpartitioned Kudu tables are inefficient for large data sizes. > I see. Thank you for clarifying on this and filing the issue. Kudu range partitions are analyzed here: https://github.com/apache/impala/blob/4fa6b5260d9e28dee63a87de3bea1434706a9d05/fe/src/main/java/org/apache/impala/analysis/RangePartition.java#L156 My first tip to solve the issue is to add dates as valid keys in KuduUtil.java - isSupportedKeyType() It is possible that further changes will be needed (timestamp columns already have some special hacks). I would prefer to add support for date range partitions in this change, as it seems a fairly common use case to me. -- To view, visit http://gerrit.cloudera.org:8080/14705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91656749a58ac769b54c2a63bdd4f85c89520b32 Gerrit-Change-Number: 14705 Gerrit-PatchSet: 12 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Tue, 28 Jan 2020 15:17:58 +0000 Gerrit-HasComments: Yes
