Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14705 )
Change subject: IMPALA-8800: Added support of Kudu DATE type to Impala ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/14705/8/fe/src/main/java/org/apache/impala/util/KuduUtil.java File fe/src/main/java/org/apache/impala/util/KuduUtil.java: http://gerrit.cloudera.org:8080/#/c/14705/8/fe/src/main/java/org/apache/impala/util/KuduUtil.java@387 PS8, Line 387: isSupportedKeyType > Date should be added here. See my comment in kudu_create.test Done http://gerrit.cloudera.org:8080/#/c/14705/8/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test: http://gerrit.cloudera.org:8080/#/c/14705/8/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test@363 PS8, Line 363: Unpartitioned Kudu tables are inefficient for large data sizes. > I agree that it would preferable to just fix this in this patch, unless it Done http://gerrit.cloudera.org:8080/#/c/14705/8/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test@363 PS8, Line 363: Unpartitioned Kudu tables are inefficient for large data sizes. > Kudu range partitions are analyzed here: https://github.com/apache/impala/b Done http://gerrit.cloudera.org:8080/#/c/14705/12/testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test File testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test: http://gerrit.cloudera.org:8080/#/c/14705/12/testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test@16 PS12, Line 16: cast('1987-05-19 00:00:00' as timestamp), 0.000000001, 1.00, 1, DATE '1970-01-01') > shouldn't we also have test values before 1970-01-01? Done -- To view, visit http://gerrit.cloudera.org:8080/14705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91656749a58ac769b54c2a63bdd4f85c89520b32 Gerrit-Change-Number: 14705 Gerrit-PatchSet: 13 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Fri, 07 Feb 2020 09:02:02 +0000 Gerrit-HasComments: Yes
