Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15116 )
Change subject: IMPALA-5904: Add tsan_full option and fix several TSAN bugs ...................................................................... Patch Set 1: > > Does ignore_noninstrumented_modules work on Linux? Looking at the > > LLVM source, https://reviews.llvm.org/D61708 doesn't look like > it's > > been merged. > > > > FWIW, it didn't exist (and certainly didn't work on Linux) when > > Kudu's TSAN support was added, which is why we went the other > > direction and recompile all of our dependencies with > > -fsanitize=thread if doing a TSAN build. > > Maybe https://reviews.llvm.org/D28263 fixed it? > > It definitely does something on my dev machine, which is running > Ubuntu 16.04. mm ignore that review link. I'll try to see if I can find the patch that fixed it, but confirmed it works on my dev machine. -- To view, visit http://gerrit.cloudera.org:8080/15116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d7ef5c228afd5882e145e6f53885b355d6c25a0 Gerrit-Change-Number: 15116 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 28 Jan 2020 22:32:02 +0000 Gerrit-HasComments: No
