Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15116 )
Change subject: IMPALA-5904: Add tsan_full option and fix several TSAN bugs ...................................................................... Patch Set 1: > (5 comments) > > > When I run Impala-TSAN locally, it uses the TSAN code under: > '/mnt/source/llvm/llvm-5.0.1.src-p2/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc'. > I would guess it should be using the LLVM from the toolchain? > Although that class doesn't seem to exist anywhere in the > toolchain/ dir. > > I think that might be where the source was mounted during the > toolchain build? The same thing happens with ASAN (/mnt/source/llvm/llvm-5.0.1.src-p1/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:67). So I guess its okay. > > > I'm a bit confused about running TSAN builds with/without the > -build_shared_libs option and how TSAN interacts with static vs > dynamic linking (trying to mimic Kudu's TSAN usage > https://github.com/apache/kudu/blob/master/CMakeLists.txt#L385) > I don't think I know any more > > > According to the TSAN docs, everything (including third party > libs) should be build with -fsanitize=thread > (https://github.com/google/sanitizers/wiki/ThreadSanitizerCppManual#non-instrumented-code). > Not sure if we are doing that in Impala? > We're not, the toolchain is just a regular release build. Might consider doing this in a follow up JIRA, seems like a considerable amount of effort. It seems we can surface a lot of race conditions using TSAN without this. -- To view, visit http://gerrit.cloudera.org:8080/15116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d7ef5c228afd5882e145e6f53885b355d6c25a0 Gerrit-Change-Number: 15116 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 30 Jan 2020 01:54:20 +0000 Gerrit-HasComments: No
