Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15130 )
Change subject: IMPALA-9280: Time string with signed TZH token preceded by dash cannot be cast to timestamp ...................................................................... Patch Set 1: (3 comments) I don't understand the ISO timestamp edge cases enough to know for sure whether this handles all edge cases. I left a few comments though. I think maybe Gabor should take a look at this too. http://gerrit.cloudera.org:8080/#/c/15130/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15130/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-9280: Time string with signed TZH token preceded by dash cannot nit: try to make this fit on a single line. Usually the title also describes the code change rather than the bug. E.g. something like "fix parsing of timestamp with dash before TZH" http://gerrit.cloudera.org:8080/#/c/15130/1/be/src/runtime/timestamp-test.cc File be/src/runtime/timestamp-test.cc: http://gerrit.cloudera.org:8080/#/c/15130/1/be/src/runtime/timestamp-test.cc@1074 PS1, Line 1074: // Test handling of '-' separator right before TZH Maybe add an additional comment like "All of these time strings should successfully parse". http://gerrit.cloudera.org:8080/#/c/15130/1/be/src/runtime/timestamp-test.cc@1094 PS1, Line 1094: EXPECT_NE(v.time(), not_a_date_time) << "TC: " << i; Can we also check expected values for the parsed timestamps, to guard against any other correctness bugs? -- To view, visit http://gerrit.cloudera.org:8080/15130 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I24c636e75fd380f6ebd091bcb38bb60a274f0e00 Gerrit-Change-Number: 15130 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 29 Jan 2020 21:29:25 +0000 Gerrit-HasComments: Yes
