Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15130 )
Change subject: IMPALA-9280: Fix parsing of timestamp with dash before TZH ...................................................................... Patch Set 2: (3 comments) Thank you for the initial review. Patch set 2 submitted. http://gerrit.cloudera.org:8080/#/c/15130/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15130/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-9280: Fix parsing of timestamp with dash before TZH > nit: try to make this fit on a single line. Usually the title also describe Done http://gerrit.cloudera.org:8080/#/c/15130/1/be/src/runtime/timestamp-test.cc File be/src/runtime/timestamp-test.cc: http://gerrit.cloudera.org:8080/#/c/15130/1/be/src/runtime/timestamp-test.cc@1074 PS1, Line 1074: // Test handling of '-' separator right before TZH. > Maybe add an additional comment like "All of these time strings should succ Done http://gerrit.cloudera.org:8080/#/c/15130/1/be/src/runtime/timestamp-test.cc@1094 PS1, Line 1094: TimestampValue v = TimestampValue::ParseIsoSqlFormat( > Can we also check expected values for the parsed timestamps, to guard again I change the test to reuse TimestampTC struct like written in TimestampTest.Basic. And then check the hour, and minute part to verify. -- To view, visit http://gerrit.cloudera.org:8080/15130 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I24c636e75fd380f6ebd091bcb38bb60a274f0e00 Gerrit-Change-Number: 15130 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 29 Jan 2020 22:50:38 +0000 Gerrit-HasComments: Yes
