Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15132 )
Change subject: IMPALA-3343: WIP - Make impala-shell compatible with python 3. ...................................................................... Patch Set 3: (2 comments) Just passing through with a quick glance review since I did this for Kudu recently. http://gerrit.cloudera.org:8080/#/c/15132/3/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/15132/3/shell/impala_client.py@669 PS3, Line 669: print('{} {}'.format(str(e), type(e)), file=sys.stderr) Python 2.6, the default in RHEL 6, doesn't support formatting without positions. Using '{0} {1}' is most compatible. https://docs.python.org/2/library/string.html#format-string-syntax http://gerrit.cloudera.org:8080/#/c/15132/3/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/15132/3/tests/shell/test_shell_interactive.py@411 PS3, Line 411: assert history_entry in result.stdout, "'%s' not in '%s'" % (history_entry, Why the change to stdout? -- To view, visit http://gerrit.cloudera.org:8080/15132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb75e162bac0faeae3e12106c15da39cbfb8b462 Gerrit-Change-Number: 15132 Gerrit-PatchSet: 3 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 29 Jan 2020 23:20:50 +0000 Gerrit-HasComments: Yes
