David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15132 )
Change subject: IMPALA-3343: WIP - Make impala-shell compatible with python 3. ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/15132/3/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/15132/3/shell/impala_client.py@669 PS3, Line 669: print('{0} {1}'.format(str(e), type(e)), file=sys.stderr) > Python 2.6, the default in RHEL 6, doesn't support formatting without posit Done http://gerrit.cloudera.org:8080/#/c/15132/3/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/15132/3/shell/impala_shell.py@342 PS3, Line 342: > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/15132/3/shell/impala_shell.py@529 PS3, Line 529: > flake8: E226 missing whitespace around arithmetic operator Done http://gerrit.cloudera.org:8080/#/c/15132/3/shell/impala_shell.py@844 PS3, Line 844: > flake8: F841 local variable 'e' is assigned to but never used Done http://gerrit.cloudera.org:8080/#/c/15132/4/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/15132/4/shell/impala_shell.py@341 PS4, Line 341: > flake8: E129 visually indented line with same indent as next logical line Done http://gerrit.cloudera.org:8080/#/c/15132/3/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/15132/3/tests/shell/test_shell_interactive.py@411 PS3, Line 411: assert history_entry in result.stderr, "'%s' not in '%s'" % (history_entry, > Why the change to stdout? Done. Admittedly, I got a little sloppy here. I missed a print_to_stderr call in one spot, noticed that the test failed as written, but that it passed with stdout. I meant to go back and track down what happened, but just lost track of it. -- To view, visit http://gerrit.cloudera.org:8080/15132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb75e162bac0faeae3e12106c15da39cbfb8b462 Gerrit-Change-Number: 15132 Gerrit-PatchSet: 5 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 30 Jan 2020 21:27:46 +0000 Gerrit-HasComments: Yes
