Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15083 )
Change subject: IMPALA-4224: part 2: refactor filter routing table to support sinks ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/15083/6/be/src/runtime/coordinator-filter-state.h File be/src/runtime/coordinator-filter-state.h: http://gerrit.cloudera.org:8080/#/c/15083/6/be/src/runtime/coordinator-filter-state.h@167 PS6, Line 167: emplace > Based on the text from https://en.cppreference.com/w/cpp/container/unordere I switched to explicitly checking whether the entry exists before calling emplace(). http://gerrit.cloudera.org:8080/#/c/15083/6/be/src/runtime/coordinator-filter-state.h@167 PS6, Line 167: std::piecewise_construct, : std::forward_as_tuple(filter.filter_id), : std::forward_as_tuple > nit: I see it's moved from coordinator.cc but maybe we could just use std:: I wasn't able to avoid this incantation - I think the problem this incantation avoids is that FilterState is not movable because of the SpinLock. -- To view, visit http://gerrit.cloudera.org:8080/15083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876 Gerrit-Change-Number: 15083 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 30 Jan 2020 18:28:22 +0000 Gerrit-HasComments: Yes
