Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15083 )
Change subject: IMPALA-4224: part 2: refactor filter routing table to support sinks ...................................................................... IMPALA-4224: part 2: refactor filter routing table to support sinks This is some refactoring that will enable us to correctly construct a routing table where join build sinks produce filters: * The previous code relied (non-obviously) on producers being visited before consumers when walking the plan tree. This is no longer true when build sinks produce filters. The code is changed so it can construct the routing table entry when the first producer or consumer is visited (using GetOrCreateFilterState()) * The source plan node ID is added to TRuntimeFilterDesc, so that it's available when visiting consumer nodes. * The logic for adding a filter source to the routing table is factored out into a separate function AddFilterSource(), which can be used (in a later patch) for join build sinks. This change is not expected to change behaviour in any way. Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876 Reviewed-on: http://gerrit.cloudera.org:8080/15083 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/runtime/coordinator-filter-state.h M be/src/runtime/coordinator.cc M be/src/runtime/coordinator.h M common/thrift/PlanNodes.thrift M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java 5 files changed, 80 insertions(+), 54 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/15083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876 Gerrit-Change-Number: 15083 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
