Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15132 )
Change subject: IMPALA-3343: WIP - Make impala-shell compatible with python 3. ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15132/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15132/3//COMMIT_MSG@124 PS3, Line 124: No effort has been made yet to come up with a way to integrate testing of the That's a good point. > There's a part of me that wonders, since we're providing a publicly > pip-installable tarball on PyPI, is there even a need to keep generating the > tarball? Could using the locally available tarball simply be replaced with > "pip install impala-shell"? (Though I'm also sure there are ramifications to > doing that that are not occurring to me.) I can think of two reasons (not sure if they're good reasons, but they are reasons) * someone doesn't like using pip for some reason (the python packaging ecosystem is pretty fragmented). * someone has other infrastructure that consumes the tarball, e.g. deployment scripts, dockerfiles, packaging scripts. I believe my employer has some of those that wouldn't be easily convertible to use a different way of packaging the shell. That's no real reason for the Apache project to keep the maintenance burden, but it wouldn't be surprising if there were more consumers out there. -- To view, visit http://gerrit.cloudera.org:8080/15132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb75e162bac0faeae3e12106c15da39cbfb8b462 Gerrit-Change-Number: 15132 Gerrit-PatchSet: 3 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 30 Jan 2020 22:09:21 +0000 Gerrit-HasComments: Yes
