Hello Gabor Kaszab, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15130
to look at the new patch set (#5).
Change subject: IMPALA-9280: Fix parsing of timestamp with dash before TZH
......................................................................
IMPALA-9280: Fix parsing of timestamp with dash before TZH
In ISO SQL datetime format, '-' is both separator character and sign
in TZH token. If the TZH token itself doesn't start with a '+' sign
and the separator sequence contains more than one separators then the
last '-' of the separator sequence is taken as the sign of TZH.
Testing:
* Add test to query_test/test_cast_with_format.py
Change-Id: I24c636e75fd380f6ebd091bcb38bb60a274f0e00
---
M be/src/runtime/datetime-iso-sql-format-parser.cc
M tests/query_test/test_cast_with_format.py
2 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/15130/5
--
To view, visit http://gerrit.cloudera.org:8080/15130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I24c636e75fd380f6ebd091bcb38bb60a274f0e00
Gerrit-Change-Number: 15130
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
