Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15130 )
Change subject: IMPALA-9280: Fix parsing of timestamp with dash before TZH ...................................................................... IMPALA-9280: Fix parsing of timestamp with dash before TZH In ISO SQL datetime format, '-' is both separator character and sign in TZH token. If the TZH token itself doesn't start with a '+' sign and the separator sequence contains more than one separators then the last '-' of the separator sequence is taken as the sign of TZH. Testing: * Add test to query_test/test_cast_with_format.py Change-Id: I24c636e75fd380f6ebd091bcb38bb60a274f0e00 Reviewed-on: http://gerrit.cloudera.org:8080/15130 Reviewed-by: Impala Public Jenkins <[email protected]> Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/runtime/datetime-iso-sql-format-parser.cc M tests/query_test/test_cast_with_format.py 2 files changed, 10 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified Tim Armstrong: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/15130 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I24c636e75fd380f6ebd091bcb38bb60a274f0e00 Gerrit-Change-Number: 15130 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
