Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/15157 )
Change subject: IMPALA-9358: Query slowdown with inline views and hundreds of columns ...................................................................... Patch Set 1: (2 comments) > Patch Set 1: > > (2 comments) > > Thanks for making this quick-fix. Comments are more for my understanding than > about the code change. > This change seems small enough but did you have a chance to run any EE/FE > tests that touch this path as a sanity check that nothing went there? http://gerrit.cloudera.org:8080/#/c/15157/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15157/1//COMMIT_MSG@25 PS1, Line 25: Performance testing with a query with 1000 expressions of the > Not a blocking comment, feel free to skip it but would it be possible to in The repro query went from 12 sec to 1 sec. There was no noticeable time spend in the precondition now. http://gerrit.cloudera.org:8080/#/c/15157/1/fe/src/main/java/org/apache/impala/analysis/ExprSubstitutionMap.java File fe/src/main/java/org/apache/impala/analysis/ExprSubstitutionMap.java: http://gerrit.cloudera.org:8080/#/c/15157/1/fe/src/main/java/org/apache/impala/analysis/ExprSubstitutionMap.java@77 PS1, Line 77: for (int i = hint; i < lhs_.size(); ++i) { : if (lhsExpr.equals(lhs_.get(i))) return rhs_.get(i); : } > Just trying to understand this. Is it safe to assume that most equality sea The expression is typically found on the first iteration of the first loop. -- To view, visit http://gerrit.cloudera.org:8080/15157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77423d9c10e1edbb505cb210b5c072281b5d7cfc Gerrit-Change-Number: 15157 Gerrit-PatchSet: 1 Gerrit-Owner: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Wed, 05 Feb 2020 13:57:03 +0000 Gerrit-HasComments: Yes
