Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15157 )
Change subject: IMPALA-9358: Query slowdown with inline views and hundreds of columns ...................................................................... Patch Set 2: Code-Review+1 (3 comments) Nice find! The fix looks good to me. http://gerrit.cloudera.org:8080/#/c/15157/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15157/1//COMMIT_MSG@25 PS1, Line 25: Performance testing with a query with 1000 expressions of the > The repro query went from 12 sec to 1 sec. There was no noticeable time spe Could you please add the performance gain to the commit message? http://gerrit.cloudera.org:8080/#/c/15157/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15157/2//COMMIT_MSG@15 PS2, Line 15: get_hint It's "getWithHint" now. http://gerrit.cloudera.org:8080/#/c/15157/2/fe/src/main/java/org/apache/impala/analysis/ExprSubstitutionMap.java File fe/src/main/java/org/apache/impala/analysis/ExprSubstitutionMap.java: http://gerrit.cloudera.org:8080/#/c/15157/2/fe/src/main/java/org/apache/impala/analysis/ExprSubstitutionMap.java@80 PS2, Line 80: ( nit: need a space after "if" -- To view, visit http://gerrit.cloudera.org:8080/15157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77423d9c10e1edbb505cb210b5c072281b5d7cfc Gerrit-Change-Number: 15157 Gerrit-PatchSet: 2 Gerrit-Owner: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 06 Feb 2020 06:50:28 +0000 Gerrit-HasComments: Yes
