Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 )
Change subject: IMPALA-8852: Skipping short-circuit config check for coordinator only ...................................................................... Patch Set 2: (5 comments) Thanks for the change. Just a few nits. http://gerrit.cloudera.org:8080/#/c/15173/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15173/2//COMMIT_MSG@7 PS2, Line 7: Skipping Nit: Change to Skip? http://gerrit.cloudera.org:8080/#/c/15173/2//COMMIT_MSG@13 PS2, Line 13: Usually, our commit messages also have a section "Testing" to mention the tests added by this commit. This will help reviewers understand the testing done for the patch. See this for example. https://gerrit.cloudera.org/#/c/15157/ You could add something like: Added tests in JNIFrontendTest.java to verify the short-circuit check is skipped if it is coordinator-only mode. http://gerrit.cloudera.org:8080/#/c/15173/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/15173/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@719 PS2, Line 719: , Could you also mention here that this will skip the check if it is coordinator-only mode? http://gerrit.cloudera.org:8080/#/c/15173/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@806 PS2, Line 806: Nit: Extra space. http://gerrit.cloudera.org:8080/#/c/15173/2/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java File fe/src/test/java/org/apache/impala/service/JniFrontendTest.java: http://gerrit.cloudera.org:8080/#/c/15173/2/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@90 PS2, Line 90: conf.setStrings("dfs.domain.socket.path", ""); Don't we need to set dfs.client.read.shortcircuit = true here? Is the default true? -- To view, visit http://gerrit.cloudera.org:8080/15173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I373d4037f4cee203322a398b77b75810ba708bb5 Gerrit-Change-Number: 15173 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 06 Feb 2020 17:38:00 +0000 Gerrit-HasComments: Yes
